ParallelRequestExecutor: fields with @include and @skip aren't excluded, but return null#211
Open
tiagonuneslx wants to merge 1 commit intoaPureBase:mainfrom
Conversation
… and @Skip directives applied on fields should exclude them, instead of showing them as null
tiagonuneslx
commented
Feb 5, 2023
Comment on lines
-46
to
-50
| fun <T>extractOrNull(map: Map<*,*>, path : String) : T? { | ||
| try { | ||
| return map.extract(path) | ||
| } catch (e: IllegalArgumentException){ | ||
| return null |
Author
There was a problem hiding this comment.
I removed extractOrNull function because tests using this function were passing regardless of wether the value in the path was null or the path didn't exist.
tiagonuneslx
changed the title
|
fyi, this has been taken over in stuebingerb/KGraphQL@a3629cb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using ParallelRequestExecutor, @include and @Skip directives applied on fields should exclude them, instead of showing them as null (fix to #209)